fix/issue 79 pragma strncpy - #94
Merged
Merged
Conversation
tmolteno
commented
Jun 25, 2026
tmolteno
commented
Owner
- Fixes and optimizations from code review
- Fix #pragma GCC breaks CLANG and older GCCs #79: Remove GCC pragma breaking CLANG and older GCCs
- Fix nec_ground::get_radial_wire_length() returning wrong field - Fix dangling pointer in ASSERT macro (nec_debug.h) - Remove using namespace std from nec2cpp.h header - Fix multi-frequency plane wave excitation loop - Optimize safe_array::resize() to use geometric growth - Refactor c_ggrid::interpolate() for thread safety and speed - Fix safe_array BoundsViol ODR issue
Replace strncpy + pragma diagnostic suppression with memcpy, which does not trigger -Wstringop-truncation. The memcpy copies exactly 2 bytes of the mnemonic into gm[3], which is the intended behavior. Closes #79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.